Merged
Conversation
- Header is white text on dark bg - Jobs and skills are organized into adjacent columns - Better whitespacing all around Some structural changes to HTML were added to accomodate new styles.
- Align labels and inputs in profile form - Boost size of textarea inputs - Make skill edit forms one-line - Simplify form submit button values
CSS should be generic, with classes that describe the style changes but are not tied to the content of the page. In this commit, I've moved as much styling as possible into generic classes like "row" and "page" instead of using class names closely linked to the HTML content. Also added some better formatting of the CSS in general, with comment headers separating related styles.
Reasoning: A partial is file for rendering a part of an HTML page. They are useful for breaking apart a page into modular components, each with its own content and purpose.
tannerwelsh
added a commit
that referenced
this pull request
Oct 30, 2014
Improvements to styles and markup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The site now looks a little bit better, thanks to some basic CSS stylings. Starting by normalizing across browsers with normalize.css, this branch adds custom code in the
main.cssfile.The significant changes here have to do with the use of partials in Sinatra to break apart the HTML into smaller components. In this way,
profile,jobs, andskillscan be broken apart. This helps to modularize the markup so that components can be moved around and are less dependent on each other.This branch adds a dependency to the sinatra-partial gem, which adds some useful features to Sinatra's built-in partial functionality. In particular, it allows for the rendering of collections.